Pandas: Confused as to why one function is giving me a SettingwithCopyWarning, and why the other does not. Also confused as to why my solution works

Question

I am using pandas to do an analysis of NFL games. The nuances aren\'t important for this question (I think).

Here is part of (the whole function is very long and most of