Should you catch all exceptions? [closed]

Answer 1

Only catch the ones that make sense to handle for the level of abstraction at which you are writing the code. Most exceptions will only be caught at a much higher level than where they are thrown.

So yes, you are correct. :)

Answer 2

Just catch those you can and want to handle.
The logic is pretty simple, what will you do with the rest of the "throw"s?
unless there is something (logic \ logging \ error messaging) you want to do and you just going to re-throw then you have no reason to catch.

Answer 3

You should catch exceptions that you are expecting - and fail gracefully on exceptions that you aren't expecting (by catching them in a general exception handler).

In your example - creating DirectoryInfo() can throw multiple exceptions - but there is no reason you can't just

try 
{ 
   var di = new DirectoryInfo(somePath);
}
catch(Exception ex)  
{
   // Messagebox/alert the user etc, gracefully exit/cancel/throw if needed
}

It may be that you want to catch the security exception and provide some other code, well do it, but keep your 'general case' handler

try 
{ 
   var di = new DirectoryInfo(somePath);
}
catch(SecurityException ex) 
{
   // Carry on but use a default path or something etc
}
catch(Exception ex)  
{
   // Messagebox/alert the user etc, gracefully exit/cancel
}

Answer 4

Generally, you should only catch exceptions that you know how to handle. The purpose of exceptions bubbling up is to allow other parts of the code catch them if they can handle them, so catching all exceptions at one level is probably not going to get you a desired result.

At the top level, you may want to have a catch-all to give the user a friendly error message, and that would signal that your program is mis-handling something, and you may need to figure out how to handle it properly.

There are some cases (such as an OutOfMemoryException), that there really is no way to gracefully handle (other than exit), and you should definitely let those bubble up at least as far as the UI for a graceful exit.