I can not find the origin of this error when I compile in release mode. I have the impression that this error appeared without modifying my code (I try to go back with github bu
Reason:
When the classpath dependency to perf-plugin
is defined in the app-level build.gradle
file instead of project-level build.gradle
file, perf-plugin
(at runtime) get's the ASM v6 dep even though in it's POM file ASM v7 dep is declared. This triggers the IllegalArgumentException in the perf-plugin
v1.2.0
and v1.2.1
because they depend on ASM v7 however it works fine for v1.1.5
because it depend on ASM v6.
There are a host of posts here that explain why the classpath of the top level buildscript is intended to be different from the rest of the project:
Solution:
This is gradle behavior. A quick solution to this is to define the perf-plugin
dependency only in the root-project build.gradle
(which is already mentioned in the public docs).
Detailed Explanation:
root-project build.gradle
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.1'
classpath 'com.google.firebase:perf-plugin:1.2.1'
}
}
allprojects {
repositories {
google()
jcenter()
}
}
app-level build.gradle
apply plugin: 'com.android.application'
apply plugin: 'com.google.firebase.firebase-perf'
. . .
dependencies {
implementation 'com.google.firebase:firebase-perf:17.0.2'
}
root-project build.gradle
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.1'
}
}
allprojects {
repositories {
google()
jcenter()
}
}
app-level build.gradle
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.google.firebase:perf-plugin:1.2.1'
}
}
apply plugin: 'com.android.application'
apply plugin: 'com.google.firebase.firebase-perf'
. . .
dependencies {
implementation 'com.google.firebase:firebase-perf:17.0.2'
}
Comparison of $ ./gradlew clean :buildEnvironment
command on both cases shows that all the references to org.ow2.asm:asm:6.0
is converted to org.ow2.asm:asm:7.0
in case of No Bug but that didn't happened in the Bug case:
> Task :buildEnvironment
------------------------------------------------------------
Root project
------------------------------------------------------------
. . .
+--- com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta04
| | +--- org.ow2.asm:asm:6.0 -> 7.0
| | +--- org.ow2.asm:asm-util:6.0 (*)
| | +--- org.ow2.asm:asm-commons:6.0 (*)
| | +--- org.jdom:jdom2:2.0.6
| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.0 -> 1.3.31 (*)
| | \--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta04 (*)
| +--- com.google.protobuf:protobuf-java:3.4.0
| \--- com.google.protobuf:protobuf-java-util:3.4.0 (*)
\--- com.google.firebase:perf-plugin:1.2.1
\--- org.ow2.asm:asm:7.0
> Task :buildEnvironment
------------------------------------------------------------
Root project
------------------------------------------------------------
. . .
+--- com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta04
| +--- org.ow2.asm:asm:6.0
| +--- org.ow2.asm:asm-util:6.0 (*)
| +--- org.ow2.asm:asm-commons:6.0 (*)
| +--- org.jdom:jdom2:2.0.6
| +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.0 -> 1.3.31 (*)
| \--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta04 (*)
+--- com.google.protobuf:protobuf-java:3.4.0
\--- com.google.protobuf:protobuf-java-util:3.4.0 (*)
After migrating my Android project to Gradle Kotlin DSL I suddenly also receive the Can't instrument
error by the Firebase Performance Plugin for any class of the project, including third-party dependencies. The build eventually aborts with an OutOfMemoryError
. The error is
Can't instrument: ...
java.lang.IllegalArgumentException
at org.objectweb.asm.ClassVisitor.<init>(ClassVisitor.java:79)
at com.google.firebase.perf.plugin.instrumentation.InstrumentationVisitor.<init>(InstrumentationVisitor.java:55)
...
Looking at the source code of ASM's ClassVisitor I see that IllegalArgumentException
is thrown in the constructor when an unhandled api version is passed. perf-plugin requires version 7.0 of ASM. However when checking the project dependencies with ./gradlew :app:dependencies
I find out that version 6.0 of ASM is used. Obviously some other dependency requires 6.0.
I tried to explicitly overwrite the ASM dependency with
configurations.all {
resolutionStrategy.eachDependency {
if (requested.group == "org.ow2.asm") {
useVersion("7.0")
because("Version required by Firebase Performance Plugin")
}
}
}
and in the output of ./gradlew :app:dependencies
I now see that 7.0 is used but I still receive this error :(
Update: Downgrading com.google.firebase:firebase-plugins
from 1.2.0
to 1.1.5
solves the problem for me.
Update 2: As of version 2.0.0 of firebase-plugins
its usage is deprecated. The recommended solution is now to use the Performance Monitoring plugin explicitly. After migrating to the new plugin the problem is now solved for me.
Update 3: I must withdraw my previous statement. Using the Performance Monitor plugin did fix the build on my local machine but not on my Jenkins build server. Also moving the configurations.all
block mentioned above into the buildscript
block as commented by Antimonit did not fix the build, although I can see in the output of ./gradlew buildEnvironment
that ASM 7.0 is used for the build.
I had the same error, because my buildSrc
directory contained the fork of gradle android junit jacoco plugin. Once I got rid of it (actually I replaced source code fork by dependency on original plugin), error'd gone. If none of above advice helps you, try to check your buildSrc
directory.