I am trying to find out the sum of the diagonal elements in a matrix. Here, n is the size of the square matrix and a is the matrix. Can someone explain this to me what is happen
Try this for summing your second diagonal:
sum(a[i][n-i-1] for i in range(n))
The inner loop accesses these entries:
>>> n = 3
>>> [(i, n-i-1) for i in range(n)]
[(0, 2), (1, 1), (2, 0)]
And the summed value of this diagonal for your sample matrix is:
>>> n = 3
>>> sum(a[i][n-i-1] for i in range(n))
19
The mistake in your code is to use the same expression for both dimensions:
a[n-i-1][n-i-1]
which will process the first diagonal again in reverse order [(2, 2), (1, 1), (0, 0)]
giving you the same sum twice.
Since you know the positions of the diagonal elements for row i
, you can write it quite densely like:
d = sum(row[i] + row[-1-i] for i, row in a)
And, for odd sized matrices, you shouldn't add the center element twice:
if len(a)%2:
centre = len(a)//2
d -= a[centre][centre]
def sum_diagnol():
import random
sum=0
r1=int(input("row"))
c1=int(input("col"))
a=[[random.random()for col in range(c1)]for row in range(r1)]
print("enter elements")
for i in range(r1):
for j in range(c1):
a[i][j]=int(input("enter elements"))
r2=int(input("row"))
c2=int(input("col"))
b=[[random.random()for col in range(c2)]for row in range(r2)]
print("enter elements")
for i in range(r2):
for j in range(c2):
b[i][j]=int(input("enter elements"))
c=[[random.random()for col in range(c2)]for row in range(r1)]
if(c1==r2):
for i in range(r1):
for j in range(c2):
c[i][j]=0
for k in range(c2):
c[i][j]=a[j][k]*b[k][j]
else:
print("multiplication not possible")
for i in range(r1):
for j in range(c2):
print(c[i][j],end=" ")
print()
sum_diagnol()
I found a simple algorithm to accomplish this task.
Store the square matrix in a single one dimensional array.
Let 'n' be the order of square matrix.
There are two diagonals , one that starts from the leftmost element in top row and another that starts from nth element of the top row.
To get the indexes of numbers on the diagonal that starts from left most element in top row ,from the array containing all the numbers in the matrix; just add (n+1) recursively starting from index 1. That is, indexes of elements in left to right diagonal in the array are, 1, 1+(n+1) , (n+2)+(n+1) , (2n+3)+(n+1) till the last index of array.
To get the indexes of another diagonal's numbers from the array containing all the numbers in the matrix ; just add (n-1) recursively to the indexes starting from index equals to the 'n', which is the order of the square matrix. That is, indexes of elements in right to left diagonal in the array are, n, n+(n-1), (2n-1)+(n-1) and so on till the index equals to 'length of the array - (n-1)'.
If the order is odd then subtract the middle number in the array from the final sum.
The example 'c++' code is as follows:
#include<iostream>
using namespace std;
int sumOfDiagonalNumbersInSquareMatrix(int numberArray[],int order){
int sumOfLeftToRightDiagonal = 0;
int sumOfRightToLeftDiagonal = 0;
int length = order*order;
for(int i=0; i<length;i+=(order+1)){
//cout<<numberArray[i]<<"\t";
sumOfLeftToRightDiagonal = sumOfLeftToRightDiagonal + numberArray[i];
}
for(int i=(order-1);i<=length-order;i+=(order-1)){
//cout<<numberArray[i]<<"\t";
sumOfRightToLeftDiagonal = sumOfRightToLeftDiagonal + numberArray[i];
}
if(order % 2 != 0){
return (sumOfLeftToRightDiagonal + sumOfRightToLeftDiagonal) - numberArray[(length/2)];
}
return (sumOfLeftToRightDiagonal + sumOfRightToLeftDiagonal);
}
int main(){
int nums[] = {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16};
cout<<sumOfDiagonalNumbersInSquareMatrix(nums,4);
return 0;
}
You can run it here: http://cpp.sh/6cmdp
try this:
n=3
sum_second_diagonal=sum([a[i][j] for i in range(n) for j in range(n) if i==j]) #it will add when i==j