I am using PostgreSQL 10.1, going right to the point...
Lets say I have a TABLE:
CREATE TABLE public.document (
id
Try following:
Instead of writing the query into the USING(...)
clause put the query into a STABLE
function with a very high cost.
By doing so the function should not be called very often now - ideally only once per query lifetime, because the cost of calling the function seems now very high to Postgres. Marking the function as STABLE
tells Postgres that the result of the function doesn't change during a single query lifetime. I think that is correct for your query, isn't it?
Read more about about this two parameters here.
Like this:
CREATE OR REPLACE FUNCTION check_permission () RETURNS BOOLEAN AS $$
SELECT EXISTS (
SELECT 1 FROM public.user WHERE (is_current_user) AND ('r' = ANY(privileges))
)
$$ LANGUAGE SQL STABLE COST 100000;
And the policy now:
CREATE POLICY document_policy ON public.document FOR SELECT
USING (check_permission());
Hopefully this will give you better performance. But be aware, this only works correctly if it is OK to mark the function as STABLE
. If your function could return different results during a single query lifetime then this wouldn't work correctly and you would end up with weird results.
I have solved this from the time of posting... Anyone facing this issue, this is how I did it:
My solution was to have a private SECURITY DEFINER
"wrapper" function containing the propper query and another public function which calls the private one and INNER JOINS
the table which requires access control.
So in the specific case above, it would be something like this:
CREATE FUNCTION private.filter_document() RETURNS SETOF public.document AS
$$
SELECT * FROM public.document WHERE (
to_tsvector(
'english',
content || ' ' || COALESCE(title, '')
) @@ plainto_tsquery('english', fulltext_search_documents.search_text)
)
$$
LANGUAGE SQL STABLE SECURITY DEFINER;
----
CREATE FUNCTION public.filter_document() RETURNS SETOF public.document AS
$$
SELECT filtered_d.* FROM private.filter_documents() AS filtered_d
INNER JOIN public.document AS d ON (d.id = filtered_d.id)
$$
LANGUAGE SQL STABLE;
Since I was using Postgraphile (which is super awesome BTW!), I was able to omit introspection of the private schema, making the "dangerous" function inaccessible! With proper security implementations, the end-user will only see the final GraphQL schema, complately removing Postgres from the outside world.
This worked beautifly! Until recently when Postgres 10.3 was released and fixed it, dropping the need for this hack.
On the other hand, my RLS policies are very complex, nested and go really deep. The tables which they are run agains are also quite large (roughly 50,000+ entries to run RLS against in total). Even with super complex and nested policies, I managed to maintain the performance within reasonable boundries.
When working with RLS, keep in mind the following:
INDEXES
STABLE
and have a high COST
(like @mkurtz pointed out); or are IMMUTABLE
EXPLAIN ANALYZE
and try optimizing it as much as possibleHope you guys find the information helpful as much as I did!