Optimize ternary operator

Question

I came across this code written by someone else. Is this usage of the conditional operator recommended or commonly used? I feel it is less maintainable - or is it just me? Is th

Answer 1

Others already said how awful that code excerpt is, with nice explanations. I will just provide few more reasons why that code is bad :

1. if you consider one "if-else" to implement exactly one feature, then it is clear how complex that code is. In your case, I can not even count number of ifs.

2. It is obvious that your code is breaking breaking the single responsibility principle, which tells :

   ...a class or module should have one, and only one, reason to change.

3. unit testing that would be a nightmare, which is another red flag. And I bet that your colleague didn't even try to write unit tests for that piece of code.