Return file download from byte[]

Question

This code

string xml = XmlHelper.ToXml(queryTemplate);

byte[] xmlb = StringHelper.GetBytes(xml);

var cd = new System.Net.Mime.ContentDisposition
{
    // for e         


        

Answer 1

In this case:

public static byte[] GetBytes(string str)
{
    byte[] bytes = new byte[str.Length * sizeof(char)];
    System.Buffer.BlockCopy(str.ToCharArray(), 0, bytes, 0, bytes.Length);
    return bytes;
}

You will end up with UTF-16LE encoding, because that's what a char array is internally.

You should get rid of that function because it's both misleading and redundant duplication of functionality already existing out of the box because System.Text.Encoding.Unicode.GetBytes already does the same thing: An encoding for the UTF-16 format using the little endian byte order.

If creating a temporary file without specifying encoding works, then you probably want Windows-1252 because that was most likely being used implicitly when creating the file:

Encoding enc = Encoding.GetEncoding(1252);
byte[] xmlb = enc.GetBytes(xml);

If you wanted UTF-8 you would do:

byte[] xmlb = Encoding.UTF8.GetBytes(xml);