Is DCL still broken?

Question

As far as I understand with old JMM the DCL (Double checked Locking) trick to implement lazy singletone was broken, but i tought that it was fixed with new JMM and volatile

Answer 1

It was fixed in Java 5.

However these days the "correct" (i.e. the simplest) way is to use an enum for lazy initialization.

public enum Singleton {
    INSTANCE;

    // No need for a getInstance() method
    //public static Singleton getInstance() {
    //    return INSTANCE;
    //}
    // Add methods to your liking
}