Variable length array of non-POD element type 'string' (aka 'basic_string') c++

Question

I get this error in my c++ code Variable length array of non-POD element type string (aka basic_string).

string words[n         


        

Answer 1

This initializes words with numWords empty strings then appends the actual strings afterwards:

vector words (numWords);

while(repFile >> x)
    words.push_back(x);

Change to:

vector words;

while(repFile >> x)
    words.push_back(x);

or:

vector words (numWords);

int idx = 0;
while(repFile >> x /* && idx < numWords */)
    words[idx++] = x;

EDIT:

There is no reason to count the number of words before populating the vector:

vector words;
ifstream repFile("//Users//bobthemac//Documents//c++asignment//c++asignment//test1.txt");
if (repFile.is_open())
{
    while(repFile >> x)
    {
        words.push_back(x);
    }
    repFile.close();
}