Try/Catch inside or outside functions

Question

I have a very basic question about best practice of using try/catch. I have a simple function (DAO) like this

public void addVehicl         


        

Answer 1

AFAIK the best practice will be smth like that:

public void addVehicle(Vehicle vehicle) {
        em.getTransaction().begin();
        try {
            em.persist(vehicle);
            em.getTransaction().commit();
        } catch (Exception e) {
            if (em.getTransaction().isActive()) {
                try {
                   em.getTransaction().rollback();
                } catch (Exception e) {
                   // Log rollback failure or something
                }
            }
            throw new RuntimeException(e);
        } 
}