pipe is returning empty string in bash in git for windows

Question

Edit: Issue has been resolved after update to Git for Windows >= 2.9.0.windows1

---

Disclaimer

Some comments are referring to full \"story\" behind this is

Answer 1

basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

This seems like an example of the XY problem. Let us break down this line:

echo "$0"

This is usually the path to the script, for example ./alfa.sh

sed -e 's,\\,/,g'

This replaces backslashes with forward slashes. This is where this line starts to fall apart:

1. You dont need the -e, you can just do sed 's,\\,/,g'

2. You probably dont need the g, usually just going to be one slash as shown above

3. Changing the slashes doesnt really make sense. Bash, even on Windows, is going to be using forward slashes already

4. If for some reason the slashes do need to be changed, Sed is not the right tool for this anyway, cygpath is:

   $ cygpath -m 'C:\Program Files\Mozilla Firefox\firefox.exe'
   C:/Program Files/Mozilla Firefox/firefox.exe
   

dirname

Now you are calling dirname after sed/cygpath. It should be called before, that way sed/cygpath dont have to replace as much:

basedir=$(cygpath -m "$(dirname "$0")")

Finally, the sed command is bad for another reason; if you are going to be spitting out a path, it should be an absolute one, because why not?

basedir=$(cygpath -am "$(dirname "$0")")

Notice now that no pipe is even involved. I will also add that this problem was introduced recently to the NPM repo. You might comment to the devs there.