Accessing Internet after update and telemetry was disabled

Question

I just installed the VScode Windows zip version with vim extension on Windows 7. For privacy I disabled these options in the settings.json file:

{
&q         


        

Answer 1

Check also the version of Git you are using with VSCode.

Starting Git 2.19 (Q3 2019), possible telemetry can be sent from IDE/products using Git.

See commit 7545941 (13 Jul 2018) by Jeff Hostetler (jeffhostetler).
Helped-by: Eric Sunshine (sunshineco), René Scharfe (rscharfe), Wink Saville (winksaville), and Ramsay Jones (jeffhostetler).
^{(Merged by Junio C Hamano -- gitster -- in commit a14a9bf, 15 Aug 2018)}

Junio C Hamano, official maintainer for Git, added in this thread:

Transport (or file) can stay outside the core of this "telemetry" thing---agreeing on what and when to trace, and how the trace is represented, and having an API and solid guideline, would allow us to annotate the code just once and get useful data in a consistent way.

Ævar Arnfjörð Bjarmason added here:

To elaborate a bit on Jeff's reply (since this was discussed in more detail at Git Merge this year), the point of this feature is not to ship git.git with some default telemetry, but so that in-house users of git like Microsoft, Dropbox, Booking.com etc. can build & configure their internal versions of git to turn on telemetry for their own users.

There's numerous in-house monkeypatches to git on various sites (at least Microsoft & Dropbox reported having internal patches already).

Something like this facility would allow us to agree on some implementation that could be shipped by default (but would be off by default), those of us who'd make use of this feature already have "root" on those user's machines, and control what git binary they use etc, their /etc/gitconfig and so on.

So, in addition of Microsoft/vscode issue 16131, we will have to monitor how VSCode uses Git in the future, since Git will offer a telemetry framework, for editors to use if they choose to.

---

With Git 2.25 (Q1 2020), We have had compatibility fallback macro definitions for "PRIuMAX", "PRIu32", etc.
But we did not for "PRIdMAX", while the code used the last one apparently without any hiccup reported recently.

The fallback macro definitions for these macros that must appear in C99 systems have been removed.

See commit ebc3278 (24 Nov 2019) by Hariom Verma (harry-hov).
^{(Merged by Junio C Hamano -- gitster -- in commit e547e5a, 05 Dec 2019)}

git-compat-util.h: drop the PRIuMAX and other fallback definitions

^{Signed-off-by: Hariom Verma
Helped-by: Jeff King}

Git's code base already seems to be using PRIdMAX without any such fallback definition for quite a while (75459410edd (json_writer: new routines to create JSON data, 2018-07-13), to be precise, and the first Git version to include that commit was v2.19.0).

Having a fallback definition only for PRIuMAX is a bit inconsistent.

We do sometimes get portability reports more than a year after the problem was introduced.

This one should be fairly safe.

PRIuMAX is in C99 (for that matter, SCNuMAX, PRIu32 and others also are), and we've been picking up other C99-isms without complaint.

The PRIuMAX fallback definition was originally added in 3efb1f343a ("Check for PRIuMAX rather than NO_C99_FORMAT in fast-import.c.", 2007-02-20, Git v1.5.1-rc1 -- merge).
But it was replacing a construct that was introduced in an even earlier commit, 579d1fbfaf ("Add NO_C99_FORMAT to support older compilers.", 2006-07-30, Git v1.4.2-rc3), which talks about gcc 2.95.

That's pretty ancient at this point.

[jc: tweaked both message and code, taking what peff wrote]
Signed-off-by: Junio C Hamano