Advantages/Disadvantages of different implementations for Comparing Objects

Question

This questions involves 2 different implementations of essentially the same code.

First, using delegate to create a Comparison method that can be used as a parameter whe

Answer 1

There really is no advantage to either option in terms of performance. It's really a matter of convenience and code maintainability. Choose the option you prefer. That being said, the methods in question limit your choices slightly.

You can use the IComparer interface for List.Sort, which would allow you to not duplicate code.

Unfortunately, BinarySearch does not implement an option using a Comparison, so you cannot use a Comparison delegate for that method (at least not directly).

If you really wanted to use Comparison for both, you could make a generic IComparer implementation that took a Comparison delegate in its constructor, and implemented IComparer.

public class ComparisonComparer : IComparer
{
    private Comparison method;
    public ComparisonComparer(Comparison comparison)
    {
       this.method = comparison;
    }

    public int Compare(T arg1, T arg2)
    {
        return method(arg1, arg2);
    }
}