I recently upgraded my Mac to High Sierra
After the upgrade, Macvim (mvim) stopped working because (I assume) HighSierra upgraded ruby to 2.3, and mvim
What helped in my case was:
brew link --overwrite vim
In your case, it might be useful to use the same command for MacVim
brew link --overwrite macvim