When to unsubscribe a subscription

Question

I have a question regarding how to unsubscribe an observable. I have two codes and I\'m not really sure about which one is better.

Example 1 -> Unsubscribe the subscribe

Answer 1

I think that depends on your needs. If the activity won't wait for any other calls, I suppose you could unsubscribe inside onCompleted().

I always unsubscribe in onDestroy()

@Override
protected void onDestroy() {
    super.onDestroy();

    if (subscription != null) {
        subscription.unsubscribe();
    }
}

EDIT: take a look at http://reactivex.io/RxJava/javadoc/rx/subscriptions/CompositeSubscription.html

private CompositeSubscription mCompositeSubscription = new CompositeSubscription();

private void doSomething() {
    mCompositeSubscription.add(
        AndroidObservable.bindActivity(this, Observable.just("Hello, World!"))
       .subscribe(s -> System.out.println(s)));
}

@Override
protected void onDestroy() {
    super.onDestroy();
    mCompositeSubscription.unsubscribe();
}